3 ms·

Not just stylistic choices - I absolutely love the way ex. gitlab lets you do a suggested change in a comment, precisely because it lets me do all the work and

Not just stylistic choices - I absolutely love the way ex. gitlab lets you do a suggested change in a comment, precisely because it lets me do all the work and the MR owner just has to click to accept if they agree. That lowers the bar for what I'm willing to bring up in the first place (though I personally still don't like to comment on matters of style or taste) while making it less work for everyone, which makes it much easier to give useful suggestions:)

mixmastamyk 2y ago
Is that new? I don’t remember that feature, working with gitlab a few months back.
- chipdart 2y ago
  > Is that new? It's neither new nor novel. Even GitHub allows anyone to post a commit on a feature branch, regardless of who created it. It's not a GitLab or GitHub feature. It's a Git feature: the ability to post a commit to a branch.
  - bdangubic 2y ago
    create alias dont-fuck-with-my-branch git reset --hard HEAD~1 git push -f :)
    - chipdart 2y ago
      Services like GitHub and GitLab support preventing changes that overwrite a repo's history, in addition to tracking history even when you force update a branch.
      - bdangubic 2y ago
        I was just joking but surely I can revert a commit on a feature branch, no?
        chipdart 2y ago
        You can revert and even force-update the branch to rewrite it's history, but GitHub still tracks the old commits and even lists in the PR the events that rewrote the branch history.
        bdangubic 2y ago
        sorry for misunderstanding, I am NOT trying to hide the fact I reverted, hence the alias dont-fuck-with-my-branch :) and I was overall just joking…
  - Anon1096 2y ago
    I'm not sure about gitlab, but on github this is a distinct feature where you post a comment wrapped in three backticks and the language as suggestion. It'll format it as a diff that the author can one-click create a commit from. https://github.blog/news-insights/product-news/suggested-changes-update/ https://github.blog/news-insights/product-news/suggested-cha...

mixmastamyk 2y ago

Is that new? I don’t remember that feature, working with gitlab a few months back.

chipdart 2y ago
> Is that new? It's neither new nor novel. Even GitHub allows anyone to post a commit on a feature branch, regardless of who created it. It's not a GitLab or GitHub feature. It's a Git feature: the ability to post a commit to a branch.
- bdangubic 2y ago
  create alias dont-fuck-with-my-branch git reset --hard HEAD~1 git push -f :)
  - chipdart 2y ago
    Services like GitHub and GitLab support preventing changes that overwrite a repo's history, in addition to tracking history even when you force update a branch.
    - bdangubic 2y ago
      I was just joking but surely I can revert a commit on a feature branch, no?
      - chipdart 2y ago
        You can revert and even force-update the branch to rewrite it's history, but GitHub still tracks the old commits and even lists in the PR the events that rewrote the branch history.
        bdangubic 2y ago
        sorry for misunderstanding, I am NOT trying to hide the fact I reverted, hence the alias dont-fuck-with-my-branch :) and I was overall just joking…
- Anon1096 2y ago
  I'm not sure about gitlab, but on github this is a distinct feature where you post a comment wrapped in three backticks and the language as suggestion. It'll format it as a diff that the author can one-click create a commit from. https://github.blog/news-insights/product-news/suggested-changes-update/ https://github.blog/news-insights/product-news/suggested-cha...