4 ms·
* I've seen good/great people call out the nitpicks (in my case it was often mis-spelling, due to not being a native speaker of english) but will approve the PR
by dec0dedab0de 2y ago
* I've seen good/great people call out the nitpicks (in my case it was often mis-spelling, due to not being a native speaker of english) but will approve the PR anyway (implicitly expecting another revision to be sent, trusting the submitter).*
I always thought this was the best way.
I wish these systems had a way to assign severity to comments, and urgency to the commit.
If you have a jr developer it is your job to give them stylistic feedback, the problem comes from mixing it in with security holes or sneaky bugs. And when the process doesn’t identify when we need to ship it yesterday, vs in the next few months.
- yjftsjthsd-h 2y agoDepending on your company culture, you can also just explicitly write something like "This is not a blocker, but I would suggest...". Of course if your culture uses explicit "press the button to unblock" then that's probably redundant.
- to11mtm 2y agoYeah I do similar and encourage colleagues/orgs to do the same.
- erik_seaberg 2y agoHalf of my comments were "nit: consider blah blah" where I want it on his radar, but I approved anyway and if he declines I'm fine with it.
- fmbb 2y agoI like https://blog.danlew.net/2020/04/15/the-logaf-scale/ https://blog.danlew.net/2020/04/15/the-logaf-scale/