3 ms·
Those are some pointless tests. E.g. test_activation_stats_functions [1] that just checks that the returned value is a float, and that it can take random numbe
by tommiegannert 2y ago
Those are some pointless tests.
E.g. test_activation_stats_functions [1] that just checks that the returned value is a float, and that it can take random numbers as input.
test_get_state_dict_custom_unwrap [2] is probably supposed to check that custom_unwrap is invoked, but since it doesn't either record being called, or transform its input, the assertions can't actually check that it was called.
[1] https://github.com/huggingface/pytorch-image-models/pull/2331/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33R116 https://github.com/huggingface/pytorch-image-models/pull/233...
[2] https://github.com/huggingface/pytorch-image-models/pull/2331/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33R164 https://github.com/huggingface/pytorch-image-models/pull/233...