3 ms·
I will say that code reviews with some individuals have been, by far, the most stressful and demotivating part of my job, and a major reason why I am looking to
by deanmoriarty 2y ago
I will say that code reviews with some individuals have been, by far, the most stressful and demotivating part of my job, and a major reason why I am looking to end a career in developing software in teams, and I would not be surprised if this caused long-term health effects. In some situations, I could feel the blood flow changing in my body, an increased heart beat and blood pressure.
This is especially true in companies with a heavy culture of code reviews, and can be terrifying when a new team member joins and you are waiting for them to reveal what their "code review style" is going to be.
Many times it’s an exhausting “I know my code works, it is fairly robust to the current challenges we are facing, it is well readable and commented, and yet you are shitting on it so much that if we weren’t in a corporate environment I would straight up just tell you to go fuck off”.
In a particular team I worked at Google, it was common to see for fairly small and reasonable PRs (100-500 LOC range including tests) get ~50 or more comments by many people, including extremely opinionated ones (and this was after all the automated linters and code formatters ran, mind you). The irony was that many times the comments left by people were directly at odds with each other (reviewer A: “we should change this variable name from foo to bar” -> code gets edited to bar -> reviewer B: “we should change this variable from bar to foo”).
Conversely, the happiest time in my career was at an early stage startup where the team was so small that each engineer was the full owner and sole developer of a system (one on UI, one on backend system A, one on backend system B) and so we did not enforce any code reviews, we would just informally discuss and review the API surface for integration purposes. Naturally that only lasted until we got to PMF, and then each team was scaled, slowly but surely reintroducing nit-picking code reviews.
- trowawyu8987dt 2y agoI wonder how many people has all this sh*t cargo culting and nit-picking has sent to grave.