4 ms·

I guess it's these two files? The original 2600+ lines of C++: https://gitlab.freedesktop.org/asahi/mesa/-/blob/main/src/gallium/auxiliary/tessellator/tessella

I guess it's these two files? The original 2600+ lines of C++: https://gitlab.freedesktop.org/asahi/mesa/-/blob/main/src/gallium/auxiliary/tessellator/tessellator.cpp https://gitlab.freedesktop.org/asahi/mesa/-/blob/main/src/ga... The translated code: https://gitlab.freedesktop.org/asahi/mesa/-/blob/main/src/asahi/lib/shaders/tessellator.cl https://gitlab.freedesktop.org/asahi/mesa/-/blob/main/src/as...

whatever1 2y ago
She is not doing CI/CD so the PMs would fire her in any modern company. "Where are the unit tests?!? How is it possible to write code without tests and 100% coverage!"
- wmf 2y ago
  OpenGL and Vulkan have tons of tests and Alyssa runs them. I don't know if it's automated through CI.
  - manmal 2y ago
    Reportedly, the lack of M3 support so far is because there is no M3 Mac Mini which they can use for CI.
    - fl0id 2y ago
      That was one reason to delay it, but another more important they said was to implement gpu things like this and other missing features.
    - spockz 2y ago
      I’m sure if that is the issue we can together find a way to sponsor a MacBook with an M3? Or does it specifically have to be a Mac mini?
      - manmal 2y ago
        I can only guess, but it might be a requirement to have the machine hosted by a cloud platform.
worstspotgain 2y ago
Is there a blog post about what specifically she found to be inscrutable? The C++ doesn't look all that terse at a syntactic level, and has plenty of comments. Are the problems at the domain level?
- raggi 2y ago
  the original had more microsoft smells https://microsoft.github.io/DirectX-Specs/d3d/archive/images/d3d11/tessellator.cpp https://microsoft.github.io/DirectX-Specs/d3d/archive/images...
- samus 2y ago
  I can imagine she was glad it took only some gentle massaging to make it work. If she had encountered road blocks there, she would have had to dig in for real. The code is quite low on comments and doesn't really explain the math there. It probably makes sense if you have background in the lofty math side of computer graphics, but that's a slightly different skillset than being able to reverse-engineer and bring up exotic hardware.
raverbashing 2y ago
Honestly it doesn't look too bad A lot of the size is just because the code deals with a lot of 3/4 dim stuff and also some things are a bit more verbose in code but translate to something short in assembly

whatever1 2y ago

She is not doing CI/CD so the PMs would fire her in any modern company. "Where are the unit tests?!? How is it possible to write code without tests and 100% coverage!"

wmf 2y ago
OpenGL and Vulkan have tons of tests and Alyssa runs them. I don't know if it's automated through CI.
- manmal 2y ago
  Reportedly, the lack of M3 support so far is because there is no M3 Mac Mini which they can use for CI.
  - fl0id 2y ago
    That was one reason to delay it, but another more important they said was to implement gpu things like this and other missing features.
  - spockz 2y ago
    I’m sure if that is the issue we can together find a way to sponsor a MacBook with an M3? Or does it specifically have to be a Mac mini?
    - manmal 2y ago
      I can only guess, but it might be a requirement to have the machine hosted by a cloud platform.

worstspotgain 2y ago

Is there a blog post about what specifically she found to be inscrutable? The C++ doesn't look all that terse at a syntactic level, and has plenty of comments. Are the problems at the domain level?

raggi 2y ago
the original had more microsoft smells https://microsoft.github.io/DirectX-Specs/d3d/archive/images/d3d11/tessellator.cpp https://microsoft.github.io/DirectX-Specs/d3d/archive/images...
samus 2y ago
I can imagine she was glad it took only some gentle massaging to make it work. If she had encountered road blocks there, she would have had to dig in for real. The code is quite low on comments and doesn't really explain the math there. It probably makes sense if you have background in the lofty math side of computer graphics, but that's a slightly different skillset than being able to reverse-engineer and bring up exotic hardware.

raverbashing 2y ago

Honestly it doesn't look too bad A lot of the size is just because the code deals with a lot of 3/4 dim stuff and also some things are a bit more verbose in code but translate to something short in assembly