4 ms·
I expected them to be API compatible. Not that it matters to me but I had looked to see.
by compressedgas 2y ago
I expected them to be API compatible. Not that it matters to me but I had looked to see.
- jankovicsandras 2y agoThis is a good point and was a difficult design decision. The reasons for changing the API are: - easier to use with untokenized corpus and questions - to fix issues with the tokenizing ( e.g. https://github.com/dorianbrown/rank_bm25/issues/38 https://github.com/dorianbrown/rank_bm25/issues/38 ); also rank_bm25 provides no default tokenizer, a naive split-on-whitespace is a wrong choice - considerably simplify the code (way less SLOC) - point out the similarities of the algorithms for educational purpuses / further development In practice, the differences are minimal ( see Example 3: comparison with rank_bm25 ).