2 ms·
I can understand the test frustration on both sides. * He's being asked to fix tests that were already failing. That can be an enormous task depending on the n
by deskr 2y ago
I can understand the test frustration on both sides.
* He's being asked to fix tests that were already failing. That can be an enormous task depending on the nature of the failure and the code base.
* The team doesn't want to merge his PR since they don't have a test. The code is presumably working without his PR and understandably they won't change a single byte without seeing tests work.
- DaiPlusPlus 2y agoIf existing tests are failing then how are they accepting any PRs at all?