4 ms·
https://github.com/flutter/flutter/pulls?q=is%3Apr+author%3Amatthew-carroll https://github.com/flutter/flutter/pulls?q=is%3Apr+author%3A... - 0 open PRs - 2 P
by stux 2y ago
https://github.com/flutter/flutter/pulls?q=is%3Apr+author%3Amatthew-carroll https://github.com/flutter/flutter/pulls?q=is%3Apr+author%3A...
- 0 open PRs
- 2 PRs merged, 1 PR closed in the past 4 years
- All PRs reviewed by a member of the Flutter team within 24hrs
- [“If I'm still supposed to write tests, even for this change, then this is probably as far as I take the PR.”](https://github.com/flutter/flutter/pull/128910#issuecomment-1592088473 https://github.com/flutter/flutter/pull/128910#issuecomment-...)
- 40+ PRs from 2019
So, disgruntled ex-employee?
- deleted 2y ago[deleted]
- deskr 2y agoI can understand the test frustration on both sides. * He's being asked to fix tests that were already failing. That can be an enormous task depending on the nature of the failure and the code base. * The team doesn't want to merge his PR since they don't have a test. The code is presumably working without his PR and understandably they won't change a single byte without seeing tests work.
- DaiPlusPlus 2y agoIf existing tests are failing then how are they accepting any PRs at all?