3 ms·
I occasionally submit PRs to open source projects on github. One time a reviewer asked me to completely rework the code for no functional difference but to just
by chasd00 2y ago
I occasionally submit PRs to open source projects on github. One time a reviewer asked me to completely rework the code for no functional difference but to just do it the way he would have done it. I just said "it fixes a bug, take it or leave it." and left it at that. It saw it was merged in eventually but couldn't really care less. I wouldn't generate too much emotional attachment to a code segment because heartbreak at some point is inevitable.