3 ms·
There's a lot of emotional weight behind every PR I do on Github. They're generally the result of dozens of hours of work, discussion with project developers, e
by Rendello 2y ago
There's a lot of emotional weight behind every PR I do on Github. They're generally the result of dozens of hours of work, discussion with project developers, etc. After all that, it could still be rejected, or need to be reworked, and discussion tone might not carry well over text, etc.
When I see Twitter-style drama on Github, it makes me sick to my stomach thinking that one day I could be the target of an impromptu dogpile.
- chasd00 2y agoI occasionally submit PRs to open source projects on github. One time a reviewer asked me to completely rework the code for no functional difference but to just do it the way he would have done it. I just said "it fixes a bug, take it or leave it." and left it at that. It saw it was merged in eventually but couldn't really care less. I wouldn't generate too much emotional attachment to a code segment because heartbreak at some point is inevitable.