3 ms·

https://gerrit.libreoffice.org/c/core/+/172801 https://gerrit.libreoffice.org/c/core/+/172801 Pretty short change for reducing O(n^2) impact with a cache. Thi

by l1n 2y ago

https://gerrit.libreoffice.org/c/core/+/172801 https://gerrit.libreoffice.org/c/core/+/172801 Pretty short change for reducing O(n^2) impact with a cache. This change includes the following scalability improvements for documents containing extremely large paragraphs: - Reduces the size of layout contexts to account for LF control chars. - Due to typical access patterns while laying out paragraphs, VCL was making O(n^2) calls to vcl::ScriptRun::next(). VCL now uses an existing global LRU cache for script runs, avoiding much of this overhead.

java-man 2y ago
Thank you. Also https://bugs.documentfoundation.org/show_bug.cgi?id=92064 https://bugs.documentfoundation.org/show_bug.cgi?id=92064 I lack the context - are they still layong out the widths of characters when wrapping?
- the_mitsuhiko 2y ago
  Probably shows a bit how little that software is used with Tibetan text if this bug was able to stay open for almost 10 years for what ultimately was a 5 line fix.
  - mmooss 2y ago
    > Probably shows a bit how little that software is used with Tibetan text ... by the LibreOffice devs in Indo-European-speaking countries.
    - the_mitsuhiko 2y ago
      Apparently by anyone if the bug description is accurate. Seemingly one cannot open sufficiently long documents let alone write into them.
      - mmooss 2y ago
        Perhaps: from the article: So long as LibreOffice could not handle long paragraphs there was essentially no free tool to publish Tibetan.
  - khaled 2y ago
    The fix looks like a 5 line fix because it is a last step in a very long process of optimizing LibreOffice text layout that started years ago. This 5 line fix could not have been possible 10 years ago simply because the code it is fixing didn't exist back then.
buovjaga 2y ago
First commit from July: https://git.libreoffice.org/core/commit/4c8f88bef948b18f3d810c29a7f83496367758a9 https://git.libreoffice.org/core/commit/4c8f88bef948b18f3d81...

by l1n 2y ago

java-man 2y ago

Thank you. Also https://bugs.documentfoundation.org/show_bug.cgi?id=92064 https://bugs.documentfoundation.org/show_bug.cgi?id=92064 I lack the context - are they still layong out the widths of characters when wrapping?

the_mitsuhiko 2y ago
Probably shows a bit how little that software is used with Tibetan text if this bug was able to stay open for almost 10 years for what ultimately was a 5 line fix.
- mmooss 2y ago
  > Probably shows a bit how little that software is used with Tibetan text ... by the LibreOffice devs in Indo-European-speaking countries.
  - the_mitsuhiko 2y ago
    Apparently by anyone if the bug description is accurate. Seemingly one cannot open sufficiently long documents let alone write into them.
    - mmooss 2y ago
      Perhaps: from the article: So long as LibreOffice could not handle long paragraphs there was essentially no free tool to publish Tibetan.
- khaled 2y ago
  The fix looks like a 5 line fix because it is a last step in a very long process of optimizing LibreOffice text layout that started years ago. This 5 line fix could not have been possible 10 years ago simply because the code it is fixing didn't exist back then.

buovjaga 2y ago

First commit from July: https://git.libreoffice.org/core/commit/4c8f88bef948b18f3d810c29a7f83496367758a9 https://git.libreoffice.org/core/commit/4c8f88bef948b18f3d81...