4 ms·
This release fixes a separate security vulnerability from the original update.
by photomatt 2y ago
This release fixes a separate security vulnerability from the original update.
- NeonNautilus 2y agoCan anyone else prove this security vulnerability actually existed?
- mirzap 2y agoIt doesn't matter. Matt didn't have the right to hijack ACF.
- jnwatson 2y agoI'm not on Matt's side, but anyone has the right to fork a GPL project and call it something else.
- mirzap 2y agoThis is not a fork. He stole the original project plugin space, its reviews, download statistics, SEO traffic, etc. It has nothing to do with GPL.
- ankleturtle 2y agoWow. I will never contribute anything to WordPress again.
- ImPostingOnHN 2y agoThat isn't what happened here.
- deleted 2y ago[deleted]
- DanielLestrange 2y agoThere is no proof, see my comment above.
- gg-plz 2y agoThe maintainers [1] and the Wordpress project’s core security team lead [2] said that the fix was already published, despite your blocking them from publishing it directly and irresponsibly disclosing the issue out of spite [3]. Was that not true? [1] https://x.com/wp_acf/status/1843376378210857441 https://x.com/wp_acf/status/1843376378210857441 [2] https://x.com/johnbillion/status/1843750679141331039 https://x.com/johnbillion/status/1843750679141331039 [3] https://x.com/johnbillion/status/1842627564453454049 https://x.com/johnbillion/status/1842627564453454049
- gg-plz 2y agoSorry, I misread, disregard. I’d delete the comment but HN won’t let me.
- ankleturtle 2y agoYou are abusing the community for your own gain. Stop!
- geerlingguy 2y agoWhat is he gaining at this point?
- deleted 2y ago[deleted]
- ankleturtle 2y agoHarm of WP Engine.
- acherion 2y agoAt the cost of also harming WP. Well done Matt. clap clap (these are sarcastic claps)
- minimaxir 2y agoThere's a reason mutually-assured destruction is abbreviated MAD.
- kuschku 2y agoHarming WPEngine is not even beneficial to Wordpress anymore. With the level of revenge matt is applying you'd think WPEngine murdered his dog or something. It just makes no sense.
- bigiain 2y agoAvoiding the embarrassment of backing down and admitting he is wrong. Apparently that's worth burning down his life's work and legacy for.
- throw16180339 2y agoIt gives him an excuse to behave the way he's always wanted to.
- youngtaff 2y ago[flagged]
- DanielLestrange 2y agoUnfortunately you have no proof of that, because the only relevant changes are actually neither introducing fixes, nor ever changing the plugin core code in a way that fixes security issues. The only thing done is removing a LOT of references, links, and instructions that would remind of WP Engine, as well as all compatibility with the POR features. Then, you added a few irrelevant changes that to the inexperienced eye look like security fixes https://plugins.trac.wordpress.org/changeset?old_path=%2Fadvanced-custom-fields%2Ftrunk%2Fincludes%2Fpost-types%2Fclass-acf-post-type.php&old=3167679&new_path=%2Fadvanced-custom-fields%2Ftrunk%2Fincludes%2Fpost-types%2Fclass-acf-post-type.php&new=3167679&sfp_email=&sfph_mail= https://plugins.trac.wordpress.org/changeset?old_path=%2Fadv... However, these are no fixes. You just introduce a new variable, that you never use, and re-assign the same contents of that new variable back to the $_REQUEST Unless you show proof of a security fix - which you could have pushed to users WITHOUT renaming the plugin, WITHOUT removing original, non-security related code, and WITHOUT breaking compatibility with the PRO features - you have LIED and STOLEN code in the name of WP.ORG This will hopefully be recognized by WP Engine and if god wills, remove you from the equation once and for all legally speaking.
- seba_dos1 2y ago> However, these are no fixes. You just introduce a new variable, that you never use, and re-assign the same contents of that new variable back to the $_REQUEST While this whole takeover thing is completely ridiculous, it's you who displays an "inexperienced eye" here. What do you think the $original_post variable (which was already there) is doing, huh?
- DanielLestrange 2y agoThe same. Nothing. The “security” issue here would be that the user callback can access post and request data. Tell me one place in the entire wp code base where that is NOT possible? Security issues can be fixed WITHOUT renaming the plugin or removing links and text even if the original author has no access anymore And that “fix” is ridiculous. If anything it breaks code of users who were actually adding callbacks using that data. It’s the nature of php that you can access those details - it’s up to the caller to know what to do with it. If anything, the usage of user callback is an issue here. And in any thinkable case this ain’t a security fix that was done. A security fix would include that and only that change.