3 ms·
Passwords are just data. If said data is not tagged in a way that makes it clear it is a password, finding an algorithm that will successfully blot out password
by vidarh 2y ago
Passwords are just data. If said data is not tagged in a way that makes it clear it is a password, finding an algorithm that will successfully blot out passwords in the general case is intractable without being far too aggressive to be useful.
All such tools rely on assumptions about what will be logged following certain rules that the logging can check against - it's not hard to accidentally convert data to a format that when logged happens to fail these kinds of tests.
They should have caught it. But it's not surprising that it occasionally happens.
- tjoff 2y agoHN does it, if I post my password it will automatically change it to stars, see: *************
- benmmurphy 2y agohunter2
- yakshaving_jgt 2y agocorrect-horse-battery-staple Hmm… Not sure if it worked?
- nomilk 2y agoNot that hard [1]: Rails.application.config.filter_parameters += [ :passw, :email, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn, :cvv, :cvc ] [1] https://github.com/rails/rails/blob/8a2e28d7451d5ae4cb194fccc125a6b9554bb38b/railties/lib/rails/generators/rails/app/templates/config/initializers/filter_parameter_logging.rb.tt#L6-L8 https://github.com/rails/rails/blob/8a2e28d7451d5ae4cb194fcc...
- vidarh 2y agoAssuming, of course, that the data is logged as a parameter rather than as a raw string, or as an instance variable in another object, or any number of other ways. Developers thinking it is "not that hard" is a big red flag to me, suggesting odds are high your logs are full of things that should not be there. Using filters is a first step only.