3 ms·
Hi, respectfully, you do not appear to understand how networking works. > https://github.com/nyxpsi/nyxpsi/blob/bbe84472aa2f92e1e821039f518a528ce9585937/benche
by iczero 2y ago
Hi, respectfully, you do not appear to understand how networking works.
> https://github.com/nyxpsi/nyxpsi/blob/bbe84472aa2f92e1e821039f518a528ce9585937/benches/network_benchmark.rs#L110 https://github.com/nyxpsi/nyxpsi/blob/bbe84472aa2f92e1e82103...
This is not how you "simulate packet loss". You are not "dropping TCP packets". You are never giving your data to the TCP stack in the first place.
UDP is incomparable to TCP. Your protocol is incomparable to TCP. Your entire benchmark is misguided and quite frankly irrelevant.
As far as I can tell, absolutely no attempt is made whatsoever to retransmit lost packets. Any sporadic failure (for example, wifi dropout for 5 seconds) will result in catastrophic data loss. I do not see any connection logic, so your protocol cannot distinguish between connections other than hoping that ports are never reused.
Have you considered spending less time on branding and more time on technical matters? Or was this supposed to be a troll?
edit: There's no congestion control nor pacing. Every packet is sent as fast as possible. The "protocol" is entirely incapable of streaming operation, and hence message order is not even considered. The entire project is just a thin wrapper over the raptorq crate. Why even bother comparing this to TCP?
- vitus 2y agoI'm assuming you're getting downvoted for your tone, but your technical points are spot on.
- deleted 2y ago[deleted]
- _lvbh 2y agoThe project seems to have been made for their portfolio rather than any practical purpose (nothing wrong with that). Just a few hundred lines of hard coded server/client wrapping around raptorQ
- iczero 2y agoThey list their email as: > For more information or to contact us open a PR or email us at nyxpsi@skill-issue.dev This sounds to me like a troll. In any case, I don't think blatantly advertising your lack of expertise in networking is a good way of improving one's portfolio.
- jeroenhd 2y agoskill-issue.dev has no A or AAAA records, but it does seem to have MX records, so the email address is valid. Not very professional perhaps, but it's not unroutable at least.
- _lvbh 2y ago> I don't think blatantly advertising your lack of expertise in networking is a good way of improving one's portfolio. Who’s reading code these days? [x] Sounds cool [x] Good number of stars Hired