3 ms·
1. I'm reading not writing. 2. Is our 'large' the same? 3. I'd rather the PR were whatever size it needs to be to entirely do the thing it's supposed to do (a
by OJFord 2y ago
1. I'm reading not writing.
2. Is our 'large' the same?
3. I'd rather the PR were whatever size it needs to be to entirely do the thing it's supposed to do (and nothing else) than conform to some arbitrary size requirement.
- scott_w 2y agoYou're over-thinking it. Large PRs have a known effect of reviewers' eyes just glaze over and the PR just gets a cursory glance and LGTM :+1: on it. That's when you know a PR is "large." What's stopping you breaking such a PR into smaller chunks? Some arbitrary "it does what it's supposed to do" definition?