2 ms·
> would you spend a round trip and block it Yes. If I spend time reviewing some code and I don’t understand some part of it because of naming, it’s definitely
by thiht 2y ago
> would you spend a round trip and block it
Yes. If I spend time reviewing some code and I don’t understand some part of it because of naming, it’s definitely an issue that must be addressed during the code review. You just need to learn not to take it personally, reviewing is literally a third party coming to review your code without your biases, so they benefit from the "fresh eye". You should listen, because in 3 months you’ll be the fresh eyes trying to understand the code you wrote 3 months ago, cursing yourself for not using more descriptive names.