4 ms·
1 - time wide use a of a code formatter with an opinionated style setting to preempt such discussions is a huge productivity boon 2 - for "pattern" oriented ch
by jacobr1 2y ago
1 - time wide use a of a code formatter with an opinionated style setting to preempt such discussions is a huge productivity boon
2 - for "pattern" oriented changes that aren't easily checked in a linter, have an internal guide defining what you want in the codebase and then reference that. That again pushes the feedback back to the impersonal, and keeps it terse.
3 - leave the more substantial feedback for things like discussions around the business logic, or architecture of system, or implications of a particular change will have consequences outside the internal context of the subsystem
- tracker1 2y ago+1 on code formatting. It definitely takes care of a class of issues in practice. While I do have my own preferences, I think it's better to simply have something that can apply on save/paste and that can be the end of it. Changes to the code formatter/version and even swapping out a formatter can be relatively easy and still completely consistent. I will state that I will prefer a formatter than can apply from a command line as well as integrated plugin. I don't like formatters that rely on an IDE only plugin, I've seen this with VS in particular.
- jacobr1 2y agos/time wide/team wide/