3 ms·
Better it be a deep dive into developer sanity, a more important but comparatively under-valued metric.
by ajkjk 2y ago
Better it be a deep dive into developer sanity, a more important but comparatively under-valued metric.
- jeffbee 2y agoFor me, GitHub PR review drives me crazy. It's good for exactly one round of exchange. After that nobody can tell what the heck is going on. So my self-reported mental health would be worse. But on non-subjective metrics it seems like LLVM PRs on GitHub are gathering noticeably less discussion than they used to enjoy as Phabricator diffs.
- zeotroph 2y agoAnd just visually, GitHub wastes so much vertical space, so even trying to place what belong to which patchset becomes hard.
- another-acct 2y ago> For me, GitHub PR review drives me crazy. It's good for exactly one round of exchange. After that nobody can tell what the heck is going on. Matches my experience totally. It devolves into a heap of garbage. In comparison, with (incremental) mailing list-based review, it's not difficult to go up to v7 or so. > But on non-subjective metrics it seems like LLVM PRs on GitHub are gathering noticeably less discussion than they used to enjoy as Phabricator diffs. That could be a consequence of GitHub making it harder to comment sensibly.