3 ms·
Seems like just some people wanting to merge stuff ASAP and others having other priorities/IRL stuff and some commenters shilling our unfounded conspiracy theor
by mnau 2y ago
Seems like just some people wanting to merge stuff ASAP and others having other priorities/IRL stuff and some commenters shilling our unfounded conspiracy theories.
Yes, the 3k+ LOC, 144 file PR is 1 year old and still not merged. Join the club.
- GingerMidas 2y agoYou're missing the point, if this was just an unmerged PR no one would care. But it's likely the paid Enterprise edition has merged this already, and now the same entity has an incentive to block this from the OSS version.
- lolinder 2y ago> it's likely Says who? A random commenter on the thread who's not even the submitter of the code?
- GingerMidas 2y agoOkay let's charitably assume this PR for an Audit feature is completely unrelated to the Enterprise Audit feature introduced several months later. The reviewers of the OSS code are still heavily incentivized to block this PR. Worse, if they knew a similar feature was being built for enterprise and this would never be merged into the free version, they be wasting months of contributors' time and effort.
- techknowlogick 2y agoI commented here: https://news.ycombinator.com/item?id=41514547 https://news.ycombinator.com/item?id=41514547, but it's different code, much more of an MVP than the fully fleshed-out functionality of this PR. Hopefully, it can be merged once the technical feedback has been addressed. We've seen with other areas of the project how DB degradation can impact the whole application, and have to deal with reports from users when they run into that. I'd rather the performance impact had at the very least a work around before it gets merged so when those issues are opened, then triaging them is much easier.