4 ms·
The title is sensationalized. I read the whole thread. Gitea doesn't seem to be "blocking" the PR. They aren't preventing it from going in a release. However, t
by irskep 2y ago
The title is sensationalized. I read the whole thread. Gitea doesn't seem to be "blocking" the PR. They aren't preventing it from going in a release. However, they did pull the in-progress PR into their private repo early, presumably in order to make more money. Not great, but not bad faith.
"Blocking" would suggest to me that the PR is rejected but still ends up in the closed-source codebase, which isn't the case at all.
@dang I flagged this because we're at risk of brigading a community over a nothingburger.
- lolinder 2y ago> they did pull the in-progress PR into their private repo early, presumably in order to make more money. Not great, but not bad faith. Is this fact, or just speculation? I read the start and the end (though not the 175 items in the middle), and all I see is a vague block by a maintainer and speculation that it's because they have a similar feature in enterprise.
- GingerMidas 2y agoHypothetically, if they never finish reviewing the PR, isn't that the same as "blocking"? Ghosting is still considered a rejection and arguably a much worse one.
- ironmagma 2y agoBrigading? Well I definitely didn’t intend that, although I also don’t see anyone from here having commented on the thread so I don’t see how that is reality. Stall may have been a better word, although this PR has been crawling along for over a year now, with little response from the maintainers. If something is neglected for long enough it’s topologically equivalent to blocking it.
- irskep 2y agoI did say "at risk of" - the front page of HN is a powerful place. :-) Looks like my fears did not come to pass.
- TiredOfLife 2y ago>... but not bad faith That is literally in bad faith.
- techknowlogick 2y agoThe in-progress PR was not pulled in, different code was written to log a small subset of events that this PR does. I commented here: https://news.ycombinator.com/item?id=41514547 https://news.ycombinator.com/item?id=41514547, but the PR is more fully fleshed-out and has more functionality, which hopefully can be merged.