10 ms·
Ran into one of these when debugging an action workflow a while ago. Locally, all the tests would pass, but the tests kept failing on GitHub. Diving into the l
by timvdalen 2y ago
Ran into one of these when debugging an action workflow a while ago.
Locally, all the tests would pass, but the tests kept failing on GitHub.
Diving into the logs, the SHA that the tests were run against was not the commit we were testing locally, but the "merge candidate" that had apparently auto merged some lines of code that resulted in a syntax error.
Looking back, it makes perfect sense that _that_ is what tests are run against, but I had never realized that before (and the platform definitely hides it from you). Before we moved to GitHub actions, we were just running tests against the head of a feature branch.
- OJFord 2y ago> the platform definitely hides it from you I'm not saying it's obvious, but pull_request workflows don't run if there's a merge conflict (because it can't generate this merge candidate) which is a pretty decent pointer once you hit that.
- timvdalen 2y agoFor sure! In this case there wasn't an actual conflict, just a bad merge, and I just had not considered this at all before.