4 ms·

I get that it's still early stage, but the dependencies already look like a mess to me. No way I'm installing nui.nvim just to rock this plug-in.

by 0xCAP 2y ago

yriveiro 2y ago
Nui is a wide spread plugin in Neovim ecosystem, it’s use to have high quality UI widgets. Probably it also use Plenary for I/O as well. Not reinventing the wheel is a good thing, don’t see the problem with the dependencies.
_lvbh 2y ago
Check out that Makefile. It’s scary af: literally just downloading the latest release of a package not even controlled by the author with 0 documentation. What’s stopping the owner of that repo from uploading a supply chain attack which will get distributed to every user of Avante. Suggestion to the author: fork the repo and pin it to a hash.
- leni536 2y ago
  Not to dismiss your criticism, but I think supply chain attacks are generally a weak point of the vim/neovim plugin ecosystem, especially with all the fancy autoupdate package managers. No package signing, no audits, no curation. Just take over one popular vim package and you potentially gain access to a lot of dev departments.
deleted 2y ago
[deleted]
yetone 2y ago
Hello, I am the author of avante.nvim. Thank you for your suggestion, it's very helpful for avante.nvim! I plan to abandon nui.nvim for implementing the UI (actually, we only use nui's Split now, so it's exceptionally simple to abandon). Regarding the tiktoken_core issue, everything we did was just to make installation easier for users. However, the problem you mentioned is indeed an issue. I plan to revert to our previous approach: only providing installation documentation for tiktoken_core instead of automatically installing it for users. As for why avante.nvim must depend on tiktoken_core, it's because I've used the powerful prompts caching feature recently introduced by the Anthropic API. This feature can greatly help users save tokens and significantly improve response speed. However, this feature requires relatively accurate token count calculations, as it only takes effect for tokens greater than 1024; otherwise, adding the caching parameter will result in an error.
- gsuuon 2y ago
  The docs say that cache_control is just ignored[1] if less than 1024 tokens, maybe it's a bug if it's erroring instead? [1] https://docs.anthropic.com/en/docs/build-with-claude/prompt-caching#cache-limitations https://docs.anthropic.com/en/docs/build-with-claude/prompt-...

I get that it's still early stage, but the dependencies already look like a mess to me. No way I'm installing nui.nvim just to rock this plug-in.

by 0xCAP 2y ago

I get that it's still early stage, but the dependencies already look like a mess to me. No way I'm installing nui.nvim just to rock this plug-in.

yriveiro 2y ago

Nui is a wide spread plugin in Neovim ecosystem, it’s use to have high quality UI widgets. Probably it also use Plenary for I/O as well. Not reinventing the wheel is a good thing, don’t see the problem with the dependencies.

_lvbh 2y ago

Check out that Makefile. It’s scary af: literally just downloading the latest release of a package not even controlled by the author with 0 documentation. What’s stopping the owner of that repo from uploading a supply chain attack which will get distributed to every user of Avante. Suggestion to the author: fork the repo and pin it to a hash.

leni536 2y ago
Not to dismiss your criticism, but I think supply chain attacks are generally a weak point of the vim/neovim plugin ecosystem, especially with all the fancy autoupdate package managers. No package signing, no audits, no curation. Just take over one popular vim package and you potentially gain access to a lot of dev departments.

deleted 2y ago

[deleted]

yetone 2y ago

Hello, I am the author of avante.nvim. Thank you for your suggestion, it's very helpful for avante.nvim! I plan to abandon nui.nvim for implementing the UI (actually, we only use nui's Split now, so it's exceptionally simple to abandon). Regarding the tiktoken_core issue, everything we did was just to make installation easier for users. However, the problem you mentioned is indeed an issue. I plan to revert to our previous approach: only providing installation documentation for tiktoken_core instead of automatically installing it for users. As for why avante.nvim must depend on tiktoken_core, it's because I've used the powerful prompts caching feature recently introduced by the Anthropic API. This feature can greatly help users save tokens and significantly improve response speed. However, this feature requires relatively accurate token count calculations, as it only takes effect for tokens greater than 1024; otherwise, adding the caching parameter will result in an error.

gsuuon 2y ago
The docs say that cache_control is just ignored[1] if less than 1024 tokens, maybe it's a bug if it's erroring instead? [1] https://docs.anthropic.com/en/docs/build-with-claude/prompt-caching#cache-limitations https://docs.anthropic.com/en/docs/build-with-claude/prompt-...