3 ms·
Thanks! And the explanation of 217 makes sense too. Since I have you here, wouldn't it be better to name that type "LastByte" or something? It's not a (Rust) c
by tialaramex 2y ago
Thanks! And the explanation of 217 makes sense too.
Since I have you here, wouldn't it be better to name that type "LastByte" or something? It's not a (Rust) char, and it's not necessarily UTF-8 whereas it is definitely the last byte.
- parkmycar 2y agoHa, naming is hard! You’re totally right, it used to be just the values of the last byte of a UTF-8 char (and before that it was NonMaxU8) but now represents more. I’ll update it once I’m back at my computer, thanks!
- tialaramex 2y agoAh, while you're in there, IIRC you mention NonMaxU8 in the code still and probably that's worth updating at the same time.