3 ms·

> I actually don’t have a problem with this because just because it looked good conceptually, doesn’t me it is going to look good before going live. That's per

> I actually don’t have a problem with this because just because it looked good conceptually, doesn’t me it is going to look good before going live. That's perfectly fine. That's also not the case, though. The case in question is that when asked to review a design your assessment is that it's perfect, but only when the project comes to fruition you suddenly somehow have a series of epiphanies on how there's all sorts of problems with the design and how if you were tasked or even asked to design something you would never ever made those mistakes. That's a little different than stumbling upon emergent requirements. That's backstabbing plain and simple.

firesteelrain 2y ago
“That’s backstabbing” I think if this happens often then I would acknowledge there is a major disconnect amongst team members that this requires elevating to management. If it’s a one off, then it’s a lesson to be learned. But if it’s happening often I would want to know if it’s me or them. What can I do to make this process smoother?
- idunnoman1222 2y ago
  Lmao it’s not you
- sigseg1v 2y ago
  I've been accused of being difficult and requiring changes at the last minute but really how it played out was: - someone asked me to design review on something that was not an area within my responsibilities (turns out their business unit actually has nobody to do code review, so for everything they have to try to steal someone else's bandwidth) - I review their design and it has a lot of issues. I point them out and we do a few rounds of this. I mention to their manager at their point that I think this might be outside the scope of their skillset. They ensure me that "they are a hard worker and always produce great results". Ok then. - They go off the radar and then months later they drop an urgent 6500 line PR on me saying they need to get it into this release window. They said it's fully ready to go and tested and they are hoping to merge by tomorrow. - I go to review it and every 50 lines has totally basic flaws in it like copy-pasted code, using GPL library in a closed-source corporate product that distributes a binary to customers, making sweeping changes to code that will affect other products, breaking existing public APIs with no plan to warn customers; the works. - I spend a bunch of time explaining all the stuff that they need to rewrite or fix and all the basic mistakes they made. Then after all that, the dev gets sour with me and thinks I'm out to backstab them. If anything, I should be the one that's sour because they dumped this heaping pile of poor code at my feet and are trying to act like it's perfect and that I'm holding them up.

firesteelrain 2y ago

“That’s backstabbing” I think if this happens often then I would acknowledge there is a major disconnect amongst team members that this requires elevating to management. If it’s a one off, then it’s a lesson to be learned. But if it’s happening often I would want to know if it’s me or them. What can I do to make this process smoother?

idunnoman1222 2y ago
Lmao it’s not you
sigseg1v 2y ago
I've been accused of being difficult and requiring changes at the last minute but really how it played out was: - someone asked me to design review on something that was not an area within my responsibilities (turns out their business unit actually has nobody to do code review, so for everything they have to try to steal someone else's bandwidth) - I review their design and it has a lot of issues. I point them out and we do a few rounds of this. I mention to their manager at their point that I think this might be outside the scope of their skillset. They ensure me that "they are a hard worker and always produce great results". Ok then. - They go off the radar and then months later they drop an urgent 6500 line PR on me saying they need to get it into this release window. They said it's fully ready to go and tested and they are hoping to merge by tomorrow. - I go to review it and every 50 lines has totally basic flaws in it like copy-pasted code, using GPL library in a closed-source corporate product that distributes a binary to customers, making sweeping changes to code that will affect other products, breaking existing public APIs with no plan to warn customers; the works. - I spend a bunch of time explaining all the stuff that they need to rewrite or fix and all the basic mistakes they made. Then after all that, the dev gets sour with me and thinks I'm out to backstab them. If anything, I should be the one that's sour because they dumped this heaping pile of poor code at my feet and are trying to act like it's perfect and that I'm holding them up.