9 ms·
Rust will yell at you if you use specific magic numbers like these edit: yes, 0xCAFEBABE is a warning but 0xFEEDFACE is not: 3405691582 https://github.com/ru
by novagameco 2y ago
Rust will yell at you if you use specific magic numbers like these
edit: yes, 0xCAFEBABE is a warning but 0xFEEDFACE is not:
3405691582
https://github.com/rust-lang/rust/blob/d0ea1d767925d53b2230e2ba81197821514781f0/src/tools/tidy/src/style.rs#L59 https://github.com/rust-lang/rust/blob/d0ea1d767925d53b2230e...
- kevindamm 2y agothat sounds like 0xBADDBEEF
- esterly 2y agoOxDEADBEEF
- oguz-ismail 2y ago0xB16B00B5
- steveklabnik 2y agoThis is only for rustc, not for arbitrary rust programs.
- userbinator 2y agoThat says all I need to know about the community.
- tbrownaw 2y agoReally? Current mainstream political shibboleths are more important than for example their stance on module versioning or on whether C code should have a right to exist?
- oguz-ismail 2y agoYes.
- kragen 2y agoit seems likely that the degree of importance they accord to current mainstream political shibboleths is informative about the community's value system and decision-making process, and therefore how it will change its policy on module versioning and c code in the next few years probably some people will think it's encouraging information, and others will think it's discouraging information, but either way it's important information
- GolberThorce 2y ago>right to exist we must secure the existence of C code and a future for node children
- SanjayMehta 2y agoBut why?
- nimih 2y agoIt's a mystery, lost to the sands of time. IMO, it's highly unlikely anyone will ever discover why the maintainers of the Rust compiler decided to lint their codebase for a dozen or so magic numbers.
- SanjayMehta 2y agoI feel my leg is being pulled, ever so gently.
- fch42 2y agothe github commit's "conversations" log for the commit has a few notes you need to log in for to view. But then, the maintainer who merged said "it's just a few constants". Which is fair enough. I think this would more belong into clippy; it'd be easier extensible then, and less "magic". But I'm just a 0xf001 who's intentions are 0x900d ... please don't let me 0xbe misunderst0x0d.
- cbzbc 2y agoIt's fairly simple - and I don't know why no one has pointed this out already. If everyone starts to use the same magic numbers then they are no longer magic and you can end up with strange corner case bugs and holes where a magic number used in one context is mistaken for a magic number in another context.
- Krssst 2y agohttps://www.oxfordlearnersdictionaries.com/definition/english/babe https://www.oxfordlearnersdictionaries.com/definition/englis... > but sometimes considered offensive if used by a man to a woman he does not know There are billions of other magic numbers to choose from anyway.
- johnisgood 2y ago
- ryandrake 2y agoKind of low-key hilarious that someone thought this was a serious enough issue to actually submit that code. I wonder if there is a written spec that helps to judge which integers should be considered "problematic" and which ones aren't.
- yongjik 2y agoNot just that, but they also wrote the numbers in decimal - they didn't even want them in the code as an example of what not to do. Maybe someone was having too much fun and got carried away, but what an odd sense of humor.
- omoikane 2y ago> wrote the numbers in decimal Maybe they just didn't want the checker to flag itself. I remember there was a similar check inside Google, where any file containing the words "DO NOT SUBMIT" will cause the presubmit check to fail. Naturally the presubmit checker needs to look for that string, but it couldn't trivially include the string as-is because that would prevent the presubmit checker from being submitted. (Motivation for something like this is that if you inserted some extra logging statements or similar for debugging, you would add "DO NOT SUBMIT" in nearby comments, so that you will remember to remove them later).
- 8n4vidtmkvmk 2y agoIt's also fun if you want to include that string in a template file so that users of the template don't forget to fill in the template before submitting.
- 3836293648 2y agoBut it's clippy, you can just annotate it with an #[allow(problematic_constants)]
- Duwensatzaj 2y agoIt’s not humor. It’s religion for the irreligious.
- pton_xd 2y agoNo wonder the compile times are so slow. Rustc comes with built-in content moderation! Anyway I think they forgot a few, like 173406926 (// Intentionally written in decimal rather than hex). Seems like they just checked https://en.wikipedia.org/wiki/Hexspeak https://en.wikipedia.org/wiki/Hexspeak. Kind of a weak effort, overall.
- lkj34l34 2y ago[dead]
- Lammy 2y agoReformatted: irb> [184594741, 2880289470, 2881141438, 2965027518, 2976579765, 3203381950, 3405691582, 3405697037, 3735927486, 4027431614, 4276992702].map! { _1.to_s(16) } => ["b00b135", "abadbabe", "abbababe", "b0bababe", "b16b00b5", "beefbabe", "cafebabe", "cafed00d", "deadbabe", "f00dbabe", "feedbabe"]
- deleted 2y ago[deleted]
- hyperhopper 2y agoI wonder why are many many "babe" constants included, but only a single "d00d" constant.
- ramon156 2y agoIt's because soos is the most perfect man
- lifthrasiir 2y agoIt's probably based on the Hexspeak Wikipedia page [1], which contains 7 "babe" constants and only 2 "d00d" constants. So we already had much more "babe" magic constants to start with, I wonder why... ;-) [1] https://en.wikipedia.org/wiki/Hexspeak https://en.wikipedia.org/wiki/Hexspeak
- KineticLensman 2y agoBurn baby burn (As per the Apollo guidance computer)
- kragen 2y agoif your coworker says 'ana over in sales is a babe' they're almost certainly commenting on her appearance, not just mentioning her gender. even if they don't explicitly mention her b16 b00b5, you may reasonably wonder if they're judging you on the same basis, and in particular whether you'd have a better yearly peer evaluation if you were a dowdy man instead of a dowdy woman if they instead say 'leslie over in sales is a dood' they're just being explicit about his gender, perhaps because someone thought he was female i'm not endorsing any value judgments for or against these statements, just explaining what other people's thinking (factually) is which leads to the kind of value judgments that lead to policies against putting b00b135 in your source code i suspect cafed00d was included as a (possibly counterproductive) gesture to allay equity concerns like yours rather than because of any serious concern that a cafed00d constant would cause anyone any concern on its own
- hoseja 2y agoRustaceans NOT beating the allegations.
- ThrowawayTestr 2y agoWhat a meme language.