3 ms·
That's precisely why I love to only comment things with questions, i.e. "isn't go-to considered harmful? Is this really the best way?". It gives the person mak
by ffsm8 2y ago
That's precisely why I love to only comment things with questions, i.e. "isn't go-to considered harmful? Is this really the best way?".
It gives the person making the change the opportunity to give context for their decision - and either change or spell out their reasoning for it, potentially giving me an opportunity to learn from them.
Another good benefit is that it doesn't "attack" the PR author in the "non-violent communication" way
- blowski 2y agoDoesn't that seem a bit passive aggressive? See what I did there?
- Smaug123 2y agoYou can totally do this with non-passive-aggressive phrasings ("Is this possible using structured programming instead of GOTO? What went wrong when you tried, how messy does it get?")
- ffsm8 2y agoSurely it depends on both your phrasing and how you usually interact with your colleagues, no?