5 ms·

Spotted a bug on this. If you go back or forward in your browser to a blog post, it just shows a bunch of JSON code. You have to reload to get the site to prope

Spotted a bug on this. If you go back or forward in your browser to a blog post, it just shows a bunch of JSON code. You have to reload to get the site to properly show.

patrickod 14y ago
Also noticed this bug and wanted to mention it in case it wasn't just myself.
ebzlo 14y ago
Noticed this as well. Throw this in your JS file somewhere: $.ajaxSetup({ cache: false });
rigoneri 14y ago
Great catch, I'll fix it... The reason is that it uses the same URL for a regular HTTP request and a XMLHttpRequest...
- deleted 14y ago
  [deleted]
- MichaelApproved 14y ago
  Why did you build it that way instead of having a specific API path?
samrat 14y ago
Also, middle-clicking a link opens it in the same tab/window. Is that intentional?
- DHowett 14y ago
  I abhor things like this. Certain types of navigation completely override browser behaviour in this regard and it is somewhat maddening.
- shadowfiend 14y ago
  That and command-clicking on Mac both need to be controlled for when capturing the click event for links for sure.
- rcsorensen 14y ago
  It's set up like that in https://github.com/rigoneri/syte/blob/21ed38790bbfab3e7a73219a42b9ab2178ed9881/syte/static/js/components/links.js https://github.com/rigoneri/syte/blob/21ed38790bbfab3e7a7321... . Could be changed to only preventDefault/stopPropagation if it doesn't match one of the specially tagged links, or by setting up a different selector for the specially handled links.
- aseemk 14y ago
  Came here to mention this exact issue. (And related, e.g. cmd+clicking.) Mislav wrote a great post on how to do this robustly: http://mislav.uniqpath.com/2011/03/click-hijack/ http://mislav.uniqpath.com/2011/03/click-hijack/ Hope that helps!
rigoneri 14y ago
Issue fixed. Please let me know if you find any more issues, or create an issue in github. Thanks!!
- deleted 14y ago
  [deleted]
- shortformblog 14y ago
  Thanks for taking care of this! I like what you're doing with this. As a Tumblr-head, I think you should also consider adding follow, like and reblog functionality. The API also has functions for this. But either way, I'll be keeping an eye on this!

Spotted a bug on this. If you go back or forward in your browser to a blog post, it just shows a bunch of JSON code. You have to reload to get the site to properly show.

patrickod 14y ago

Also noticed this bug and wanted to mention it in case it wasn't just myself.

ebzlo 14y ago

Noticed this as well. Throw this in your JS file somewhere: $.ajaxSetup({ cache: false });

rigoneri 14y ago

Great catch, I'll fix it... The reason is that it uses the same URL for a regular HTTP request and a XMLHttpRequest...

deleted 14y ago
[deleted]
MichaelApproved 14y ago
Why did you build it that way instead of having a specific API path?

samrat 14y ago

Also, middle-clicking a link opens it in the same tab/window. Is that intentional?

DHowett 14y ago
I abhor things like this. Certain types of navigation completely override browser behaviour in this regard and it is somewhat maddening.
shadowfiend 14y ago
That and command-clicking on Mac both need to be controlled for when capturing the click event for links for sure.
rcsorensen 14y ago
It's set up like that in https://github.com/rigoneri/syte/blob/21ed38790bbfab3e7a73219a42b9ab2178ed9881/syte/static/js/components/links.js https://github.com/rigoneri/syte/blob/21ed38790bbfab3e7a7321... . Could be changed to only preventDefault/stopPropagation if it doesn't match one of the specially tagged links, or by setting up a different selector for the specially handled links.
aseemk 14y ago
Came here to mention this exact issue. (And related, e.g. cmd+clicking.) Mislav wrote a great post on how to do this robustly: http://mislav.uniqpath.com/2011/03/click-hijack/ http://mislav.uniqpath.com/2011/03/click-hijack/ Hope that helps!

rigoneri 14y ago

Issue fixed. Please let me know if you find any more issues, or create an issue in github. Thanks!!

deleted 14y ago
[deleted]
shortformblog 14y ago
Thanks for taking care of this! I like what you're doing with this. As a Tumblr-head, I think you should also consider adding follow, like and reblog functionality. The API also has functions for this. But either way, I'll be keeping an eye on this!