5 ms·
This seems to come very close to recognising that if someone without permissions pushes something to a repository, it should be convered into a PR. > If you've
by pkal 2y ago
This seems to come very close to recognising that if someone without permissions pushes something to a repository, it should be convered into a PR.
> If you've ever used the email workflow I don't think I need to explain why it sucks.
I prefer it FWIW. After setting up your Email, it is much easier and faster to send a mail than go through a PR-process. On the reciving end you can respond inline to the patch, in the compfort of your email client, without having to use a browser.
My feeling is that people who don't like this, don't have a good mail setup (which is understandable given some hosts), making Email much more painful to use in general.
- johnny22 2y agoIf you review PRs as whole, you don't need to use the web interface. I think it only gets harder when you want to do inline comments. At least that's what the docs for github cli suggest. https://cli.github.com/manual/gh_pr_review https://cli.github.com/manual/gh_pr_review It does seem like it would be hard to support inline comments properly outside of an email quoting context without editor integration.
- j5155 2y agoSome IDEs actually have GitHub PR integration (JetBrains ones) with full comment support. It is amazing and one of my favorite features by far.
- satvikpendem 2y agoVSCode has it via their GitHub extension.
- masklinn 2y agoAnd that can be used online, replace `GitHub.com` by `GitHub.dev` on a PR and it’ll drop you in the web based vscode.
- WorldMaker 2y agoThere's even a keyboard shortcut to do that: from the Files view of a Repo on GitHub type a dot/period (.) and it will shuttle you from .com to .dev.