4 ms·

Sure. Pull Requests tend to force users into collaborating in a web view. Further, they require a collaborator to: - have an account on the platform - fork

by qudat 2y ago

Sure. Pull Requests tend to force users into collaborating in a web view. Further, they require a collaborator to: - have an account on the platform - fork the repo - pull repo - create a branch - make the change - push to forked repo - click a button in the UI to create the PR With `git-pr` it can be this simple: - pull repo - make the change - submit pr with a single command `git format-patch | ssh host pr create x` If you've ever used the email workflow I don't think I need to explain why it sucks.

pkal 2y ago
This seems to come very close to recognising that if someone without permissions pushes something to a repository, it should be convered into a PR. > If you've ever used the email workflow I don't think I need to explain why it sucks. I prefer it FWIW. After setting up your Email, it is much easier and faster to send a mail than go through a PR-process. On the reciving end you can respond inline to the patch, in the compfort of your email client, without having to use a browser. My feeling is that people who don't like this, don't have a good mail setup (which is understandable given some hosts), making Email much more painful to use in general.
- johnny22 2y ago
  If you review PRs as whole, you don't need to use the web interface. I think it only gets harder when you want to do inline comments. At least that's what the docs for github cli suggest. https://cli.github.com/manual/gh_pr_review https://cli.github.com/manual/gh_pr_review It does seem like it would be hard to support inline comments properly outside of an email quoting context without editor integration.
  - j5155 2y ago
    Some IDEs actually have GitHub PR integration (JetBrains ones) with full comment support. It is amazing and one of my favorite features by far.
    - satvikpendem 2y ago
      VSCode has it via their GitHub extension.
      - masklinn 2y ago
        And that can be used online, replace `GitHub.com` by `GitHub.dev` on a PR and it’ll drop you in the web based vscode.
        WorldMaker 2y ago
        There's even a keyboard shortcut to do that: from the Files view of a Repo on GitHub type a dot/period (.) and it will shuttle you from .com to .dev.
makeitdouble 2y ago
On the general idea, I'm thoroughly in support of alternative interfaces and workflows, so I see git-pr as a net win. On the above steps, I feel it's misrepresenting what github/gitlab have to offer. The only real step would be "have an account on the platform" and looking at the file in a browser. From there creating a MR/PR in a new branch with the changes you want is painless and a matter of 3 or 4 clicks. It works very well for repos with config files that only need the CI to be green, you get a full MR in 1 min if you want to.
cryptonector 2y ago
Are you not skipping the public key enrollment step in your simple description of `git-pr`?

by qudat 2y ago

pkal 2y ago

This seems to come very close to recognising that if someone without permissions pushes something to a repository, it should be convered into a PR. > If you've ever used the email workflow I don't think I need to explain why it sucks. I prefer it FWIW. After setting up your Email, it is much easier and faster to send a mail than go through a PR-process. On the reciving end you can respond inline to the patch, in the compfort of your email client, without having to use a browser. My feeling is that people who don't like this, don't have a good mail setup (which is understandable given some hosts), making Email much more painful to use in general.

johnny22 2y ago
If you review PRs as whole, you don't need to use the web interface. I think it only gets harder when you want to do inline comments. At least that's what the docs for github cli suggest. https://cli.github.com/manual/gh_pr_review https://cli.github.com/manual/gh_pr_review It does seem like it would be hard to support inline comments properly outside of an email quoting context without editor integration.
- j5155 2y ago
  Some IDEs actually have GitHub PR integration (JetBrains ones) with full comment support. It is amazing and one of my favorite features by far.
  - satvikpendem 2y ago
    VSCode has it via their GitHub extension.
    - masklinn 2y ago
      And that can be used online, replace `GitHub.com` by `GitHub.dev` on a PR and it’ll drop you in the web based vscode.
      - WorldMaker 2y ago
        There's even a keyboard shortcut to do that: from the Files view of a Repo on GitHub type a dot/period (.) and it will shuttle you from .com to .dev.

makeitdouble 2y ago

On the general idea, I'm thoroughly in support of alternative interfaces and workflows, so I see git-pr as a net win. On the above steps, I feel it's misrepresenting what github/gitlab have to offer. The only real step would be "have an account on the platform" and looking at the file in a browser. From there creating a MR/PR in a new branch with the changes you want is painless and a matter of 3 or 4 clicks. It works very well for repos with config files that only need the CI to be green, you get a full MR in 1 min if you want to.

cryptonector 2y ago

Are you not skipping the public key enrollment step in your simple description of `git-pr`?