5 ms·

Worth noting for people who don't use MS tech stack much, this is the new Terminal that you get from the windows store (for free) not cmd.exe Which anyone who

Worth noting for people who don't use MS tech stack much, this is the new Terminal that you get from the windows store (for free) not cmd.exe Which anyone who knows how to actually use a terminal should have upgraded to years ago anyway, mind you.

None4U 2y ago
conhost.exe is the terminal, cmd.exe is the shell, this patch is in fact only currently used in conhost
- runevault 2y ago
  conhost is in the terminal repo? Huh interesting, that surprises me.
  - zadjii 2y ago
    Conhost and Terminal share quite a lot of code in fact. The text buffer, the renderer, the VT sequence parser - all that's the same codebase. That allows bugfixes and improvements to the the Terminal to also flow back to the vintage console (for people who still use that)
    - slyfox125 2y ago
      Interesting tidbit - thank you for sharing. That's handy for those who prefer the vintage console (including myself).
- zadjii 2y ago
  That is _technically_ correct (the best kind). There's some plumbing between conhost and Terminal we need to clean up before we can add it to Terminal too. We've got a branch ready, we've just got to merge a whole stack of PRs first before we can get there.
pathartl 2y ago
Terminal is built into newer versions of Windows 11.
- runevault 2y ago
  They added directly finally? Good to know they hadn't when I got Win 11.
  - PaulHoule 2y ago
    It's nice for me because my workplace turns off access to the Windows Store.
  - zadjii 2y ago
    We shipped it (the Terminal) with the first versions of Windows 11. I don't think the "default terminal" feature defaulted to the new Terminal in the first win11 builds, but it should now. And you can always pick whichever terminal you want as the default terminal
    - runevault 2y ago
      Really? I swear when I got my alienware I had to go to the store to install it. And I just type term when I hit the windows key anyway so default mostly doesn't matter for me, but good to know.
ashleyn 2y ago
I was about to express my surprise that such a major part of Windows was now open source on Github.
- zadjii 2y ago
  Has been for like, five years now ;)

None4U 2y ago

conhost.exe is the terminal, cmd.exe is the shell, this patch is in fact only currently used in conhost

runevault 2y ago
conhost is in the terminal repo? Huh interesting, that surprises me.
- zadjii 2y ago
  Conhost and Terminal share quite a lot of code in fact. The text buffer, the renderer, the VT sequence parser - all that's the same codebase. That allows bugfixes and improvements to the the Terminal to also flow back to the vintage console (for people who still use that)
  - slyfox125 2y ago
    Interesting tidbit - thank you for sharing. That's handy for those who prefer the vintage console (including myself).
zadjii 2y ago
That is _technically_ correct (the best kind). There's some plumbing between conhost and Terminal we need to clean up before we can add it to Terminal too. We've got a branch ready, we've just got to merge a whole stack of PRs first before we can get there.

pathartl 2y ago

Terminal is built into newer versions of Windows 11.

runevault 2y ago
They added directly finally? Good to know they hadn't when I got Win 11.
- PaulHoule 2y ago
  It's nice for me because my workplace turns off access to the Windows Store.
- zadjii 2y ago
  We shipped it (the Terminal) with the first versions of Windows 11. I don't think the "default terminal" feature defaulted to the new Terminal in the first win11 builds, but it should now. And you can always pick whichever terminal you want as the default terminal
  - runevault 2y ago
    Really? I swear when I got my alienware I had to go to the store to install it. And I just type term when I hit the windows key anyway so default mostly doesn't matter for me, but good to know.

ashleyn 2y ago

I was about to express my surprise that such a major part of Windows was now open source on Github.

zadjii 2y ago
Has been for like, five years now ;)