3 ms·
Read the code: - If you can understand it and it makes sense, feel free to rewrite the git history and accept the patch. - If you cannot understand it, ask qu
by palata 2y ago
Read the code:
- If you can understand it and it makes sense, feel free to rewrite the git history and accept the patch.
- If you cannot understand it, ask questions based on your understanding. Feel free to refuse the PR if it does not end up making sense for you.
The fact that the commit messages are not English don't matter at all IMHO: you are entitled to refuse a PR even if the commit messages are in English. What matters is whether or not you want to maintain the offered changes. And in order to do that, you need to understand the code.
- xupybd 2y agoThat's a lot of work. It really depends why they are doing it in the first place.
- palata 2y agoThat's the very basic job of being a maintainer. If you don't read and understand the code, you should just not merge it. Nothing forces you to merge contributions. But if you do, do it right.
- gus_massa 2y agoHow big are the changes? Is this a huge new feature or some small fix? My recomendation is to look at the code and secretly use Google Translate to see if they make sense. If they make sense, ask them to translate the messages, and then fix any typo of small gramar error before merging. (Some mantainers like to ask to fix any minor error, but it's anoying for the contributor.)