4 ms·
> After a rebase you have commits where no one's ever run the tests, no author ever intended to get the repo into that state. Hell, most likely no one knows if
by AceJohnny2 2y ago
> After a rebase you have commits where no one's ever run the tests, no author ever intended to get the repo into that state. Hell, most likely no one knows if the code even compiles.
That is the role of the CI system.
- lmz 2y agoCI will usually only run the latest commit. Even if commit a, b, and c were all tested, the resulting commits a', b', and c' after rebase would usually only have the last one tested.
- skybrian 2y agoSince you shouldn't publish commits that weren't tested, this suggests you should publish only one commit at a time. (Unless you think "works on my machine" is good enough testing. Sometimes it is.)
- lmz 2y agoSo rebase then force push a', wait for CI, push b', wait for CI, push c'? Personally I just squash on merge.
- account42 2y agoAnd if you care about each commit always passing all test you should change your CI config accordingly.