3 ms·
From my memory, extremely large but semantically simple changes still used global approvers since it wasn't considered worth the effort to get approval from hun
by singron 2y ago
From my memory, extremely large but semantically simple changes still used global approvers since it wasn't considered worth the effort to get approval from hundreds or thousands of individual OWNERs using rosie. Also, with a change of this magnitude, especially one affecting BUILD files, it might not have been possible to create the mega-CL that rosie uses, but I don't remember specific limitations on that.
- jrockway 2y agoThat's exactly what I remember. I did a few LSCs; one I used Rosie just to see how it worked (I recall wanting to use it for all my CLs because it submits after someone clicks approve and the tests pass), but most of the time it was easier to find a global approver and submit the whole thing atomically.
- dartos 2y agoI always appreciate these googler threads talking about all the Google internal tools. Reminds me of all the impenetrable jargon around me when I was new