4 ms·
I think the big take away is that GitHub should add a "Merges #X" feature similar to Closes #X as Daniel suggests. An additional problem with closing a pull re
by rezonant 2y ago
I think the big take away is that GitHub should add a "Merges #X" feature similar to Closes #X as Daniel suggests.
An additional problem with closing a pull request instead of "purple merging" it is that it gives off the wrong end result when you view the pull request from the pull requests view, as an activity comment in a related issue, or by viewing the top of a pull request. Red should mean change rejected and purple should mean change accepted, regardless of the mechanism by which the code was accepted.