3 ms·
> Not pulling someones PR also means he does not get any public attribution to it. He doesn't show up as a contributor, too Manually merging a commit with fixu
by detaro 2y ago
> Not pulling someones PR also means he does not get any public attribution to it. He doesn't show up as a contributor, too
Manually merging a commit with fixups does not remove any attribution, what are you talking about? Who determines "committers to this project" by looking at the list of PRs on Github instead of the contributor list in the repo, the commits in the repo, ...?
- throwanem 2y agoI suspect the concern is less about who's credited in the curl repository on Github, and more about who gets to point to evidence on Github of having contributed to curl.
- detaro 2y ago... then point to your commits in the curl repo on Github?
- throwanem 2y agoI'm not expressing a preference here; this isn't a problem I have. But I do also suspect that a project with as high a profile as curl sees a lot of trivial PRs with less intent to improve the software, than to have the merge show up on the contributor's behalf in Github's various recruiter-friendly metrics. How that intent plays with Git as Git is done, versus how Github does it, I have no idea. But the existence of the article, and the perspective toward which it seems to be written, suggest to me the answer is "not well" and that Stenberg et al may be seeing the same questions and complaints frequently recurring about this.
- detaro 2y agoBut that's my point, what are these metrics that supposedly don't show the contributions anymore? Because the (IMHO) important ones all still show it, because they go by commit authorship in the repo, so you still get listed in the important places and can point to them.
- throwanem 2y agoWell, fair enough: as I said, I don't know. The commenter with whom you originally raised the question can probably answer better there.