2 ms·
> I thought maintainers can edit pull request? Why is that not used here? The article says: > That is however a clunky, annoying and time-consuming extra-step
by jraph 2y ago
> I thought maintainers can edit pull request? Why is that not used here?
The article says:
> That is however a clunky, annoying and time-consuming extra-step that not only requires that we (always) push code to other people’s branches, it also triggers a whole new round of CI jobs. This, only to get a purple blob instead of a red one. Not worth it.
> Not pulling someones PR also means he does not get any public attribution to it
I don't believe this is the case. Edited commits can keep the author (Author:, Co-Authored-By:).
> I'd say, don't use GitHub then
I'd say this would be throwing the baby with the bathwater.
(I'd also say amen to that though.)
> the maintainers are just too stubborn to implement them.
A gross mischaracterization of Daniel, from what I see. I was lucky to attend to his presentation at FOSDEM in February, he really seems to be a nice guy.