2 ms·

> every single line you merge becomes your responsibility Your responsibility to whom?

• ff_ 2y ago
  To yourself - the code you just merged is now yours to maintain
• palata 2y ago
  Yourself. - If your build breaks in the future because of this, nobody will come help you. - If you decide in the future that you want to cross-compile to a new platform and porting contributed code is a big pain, that's on you. - If the contributed code results in crashes for some users, they will come back and complain to you. - Etc.
  • carlosjobim 2y ago
    Wouldn't you save an old version so you can take out the faulty code in the future? If users complain they can offer monetary compensation or offer to fix the code or just shut up.
    • palata 2y ago
      It depends on the kind of contribution. Sometimes it is very low-risk, i.e. you know for sure that it won't impact many users or that it is easy to revert if necessary. Sometimes it has a fundamental impact on your codebase, and if you build on top of that then it will be very hard to "just revert". It's the job of the maintainer to decide what kind of risk they are willing to take. The thing is that many contributors don't understand that and put a lot of pressure to force their contribution in. And that's how you end up burning out the maintainers who try to be nice.