3 ms·

Oh wow, you weren't kidding. Even big projects like MySQL and Textmate look like they might have that error in their codebase. https://github.com/search?type=c

Oh wow, you weren't kidding. Even big projects like MySQL and Textmate look like they might have that error in their codebase. https://github.com/search?type=code&auto_enroll=true&q=84600 https://github.com/search?type=code&auto_enroll=true&q=84600 https://github.com/mysql/mysql-server/blob/824e2b4064053f7daf17d7f3f84b7a3ed92e5fb4/sql/ssl_init_callback.cc#L219 https://github.com/mysql/mysql-server/blob/824e2b4064053f7da... https://github.com/textmate/textmate/blob/346b52b108b387462d4b3def481fb74983ae89f3/Frameworks/regexp/src/format_string.cc#L220 https://github.com/textmate/textmate/blob/346b52b108b387462d...

jrockway 2y ago
That is so smart to try it on Github. None of those look fatal but I think they all differ from the intent of the author. That's why code review is so good. You just need someone to ask "what's 874600?". Turns out: not a thing. MySQL's issue is a timeout on SSL sessions which is normally 300s. Textmate's is a "friendly" display of the time. Not a showstopper, but probably not what they had in mind. It's so easy to transpose digits. It's great to have someone ask "are you sure?".