4 ms·
> I've had to turn down dishes that wouldn't have worked for the cafe, and it makes me feel bad. I've requested users contact me before writing a PR but of cour
by gampleman 2y ago
> I've had to turn down dishes that wouldn't have worked for the cafe, and it makes me feel bad. I've requested users contact me before writing a PR but of course people don't read the FAQ.
As someone who has submitted PRs without much communication to repos asking to talk before PR are submitted: in my case these were generally cases where it just seemed easier for me as a user to just change the code rather than to contact the author, try to make some sort of social interaction online, explain why and what I'm trying to do, potentially enter some sort of negotiation trying to hammer out some agreement and then doing the code change PR dance anyway. Much easier to just make some straightforward code changes - done and dusted in a few hours.
And sure, I completely understand if a maintainer then says "no thank you". That's the risk I took by my just do it attitude. No hard feelings on my side.
- palata 2y agoI do that, too! Sometimes it makes most sense: for instance if I found and fixed a bug, I don't need to open an issue to ask permission for the PR; I just send the PR. Also many times, I find it easier to express my idea with code (by making a PR with the change) than with text. I only open an issue first if the code contribution will take a considerable amount of time and I want to make sure that the maintainer is fine with it before I start. Or if I need help from the maintainer, of course.