4 ms·
You're opening yourself up to a serious race condition by using a global variable ('params') to share state across requests. The delay between the GET and the s
by Cushman 14y ago
You're opening yourself up to a serious race condition by using a global variable ('params') to share state across requests. The delay between the GET and the socket connect could easily be seconds; under load, it will likely be next to impossible to join the right room.
You probably want to use cookies (which socket.io helpfully supplies) for this instead.
- mlakkadshaw 14y agoThanks, I'll look into it and release a update asap