5 ms·

They didn't "gut what upstream built". He published it without plugins and made a -full version that include plugins. If plugins are plugged in as default it is

by Dah00n 2y ago

They didn't "gut what upstream built". He published it without plugins and made a -full version that include plugins. If plugins are plugged in as default it isn't a plugin but a built-in feature. This is the correct way.

tdb7893 2y ago
Default plugins is a very common pattern and often what users want. There can be technical reasons but also for common features it's way to have them as opt-out instead of 99% of people needing to opt-in to the same stuff
bananenpubs 2y ago
He published it w/o core package functionality. There are no plugins with KXC, that is one of their main arguments: don't rely on 3rd party code, bring it all inhouse, where it can be checked / maintained.
- redeeman 2y ago
  as others said, core functionality that UPSTREAM THEMSELVES decided not to include in default/recommended build instructions?
  - 0x_rs 2y ago
    >UPSTREAM THEMSELVES decided not to include in default/recommended build instructions This is false, or at the very least misleading. It doesn't take much to go on the repository and give a closer look instead of repeating "what other said". Kwpolska already wrote it in this thread, -DWITH_XC_ALL (the flag that's been turned OFF in the original Debian package rules) is explicitly called in the build instructions, and not only there but also one release tool [1] and snap config [2]. This is merely how the project manages its build configuration, with specific flags turned off and one master toggle enabled by default (or expected to be passed to cmake/bash release tool). Same thing for the ppa packaging. [3] 0. https://github.com/keepassxreboot/keepassxc/blob/develop/INSTALL.md#build-steps https://github.com/keepassxreboot/keepassxc/blob/develop/INS... 1. https://github.com/keepassxreboot/keepassxc/blob/da90319d2d04e5226d2363454c80a3c6cfe132e2/release-tool.ps1#L399 https://github.com/keepassxreboot/keepassxc/blob/da90319d2d0... 2. https://github.com/keepassxreboot/keepassxc/blob/da90319d2d04e5226d2363454c80a3c6cfe132e2/snap/snapcraft.yaml#L41 https://github.com/keepassxreboot/keepassxc/blob/da90319d2d0... 3. https://github.com/keepassxreboot/keepassxc-packaging/blob/9e493e38f6febe4d8da7228e9fddb8494976868a/ubuntu-ppa/focal/keepassxc/debian/rules#L22 https://github.com/keepassxreboot/keepassxc-packaging/blob/9...
TehCorwiz 2y ago
They're not "plugins". They're compiled in features. The Debian maintainer changed one compile flag and turned off these feature which are disabled by default in the UI anyway. And changing the compile flag didn't remove the options that enable the features from the UI. So, users are very confused why the features they're trying to use don't work. Further, what happens to existing users who had these features enabled and relied on them? EDIT: link to a KeeppassXC maintainer explaining that they're not plugins: https://github.com/keepassxreboot/keepassxc/issues/10725#issuecomment-2104508951 https://github.com/keepassxreboot/keepassxc/issues/10725#iss...
- NewJazz 2y ago
  Isn't this something that Debian can do during upgrades, though? Like sure there is breakage, if you don't read the news before upgrading major versions.
- password4321 2y ago
  > changing the compile flag didn't remove the options that enable the features from the UI Hopefully this will get fixed

by Dah00n 2y ago

tdb7893 2y ago

Default plugins is a very common pattern and often what users want. There can be technical reasons but also for common features it's way to have them as opt-out instead of 99% of people needing to opt-in to the same stuff

bananenpubs 2y ago

He published it w/o core package functionality. There are no plugins with KXC, that is one of their main arguments: don't rely on 3rd party code, bring it all inhouse, where it can be checked / maintained.

redeeman 2y ago
as others said, core functionality that UPSTREAM THEMSELVES decided not to include in default/recommended build instructions?
- 0x_rs 2y ago
  >UPSTREAM THEMSELVES decided not to include in default/recommended build instructions This is false, or at the very least misleading. It doesn't take much to go on the repository and give a closer look instead of repeating "what other said". Kwpolska already wrote it in this thread, -DWITH_XC_ALL (the flag that's been turned OFF in the original Debian package rules) is explicitly called in the build instructions, and not only there but also one release tool [1] and snap config [2]. This is merely how the project manages its build configuration, with specific flags turned off and one master toggle enabled by default (or expected to be passed to cmake/bash release tool). Same thing for the ppa packaging. [3] 0. https://github.com/keepassxreboot/keepassxc/blob/develop/INSTALL.md#build-steps https://github.com/keepassxreboot/keepassxc/blob/develop/INS... 1. https://github.com/keepassxreboot/keepassxc/blob/da90319d2d04e5226d2363454c80a3c6cfe132e2/release-tool.ps1#L399 https://github.com/keepassxreboot/keepassxc/blob/da90319d2d0... 2. https://github.com/keepassxreboot/keepassxc/blob/da90319d2d04e5226d2363454c80a3c6cfe132e2/snap/snapcraft.yaml#L41 https://github.com/keepassxreboot/keepassxc/blob/da90319d2d0... 3. https://github.com/keepassxreboot/keepassxc-packaging/blob/9e493e38f6febe4d8da7228e9fddb8494976868a/ubuntu-ppa/focal/keepassxc/debian/rules#L22 https://github.com/keepassxreboot/keepassxc-packaging/blob/9...

TehCorwiz 2y ago

They're not "plugins". They're compiled in features. The Debian maintainer changed one compile flag and turned off these feature which are disabled by default in the UI anyway. And changing the compile flag didn't remove the options that enable the features from the UI. So, users are very confused why the features they're trying to use don't work. Further, what happens to existing users who had these features enabled and relied on them? EDIT: link to a KeeppassXC maintainer explaining that they're not plugins: https://github.com/keepassxreboot/keepassxc/issues/10725#issuecomment-2104508951 https://github.com/keepassxreboot/keepassxc/issues/10725#iss...

NewJazz 2y ago
Isn't this something that Debian can do during upgrades, though? Like sure there is breakage, if you don't read the news before upgrading major versions.
password4321 2y ago
> changing the compile flag didn't remove the options that enable the features from the UI Hopefully this will get fixed