4 ms·
A well-crafted commit history for a merge conveys useful information and makes reviewers’ jobs easier by splitting a large change set into smaller logical chunk
by loloquwowndueo 3y ago
A well-crafted commit history for a merge conveys useful information and makes reviewers’ jobs easier by splitting a large change set into smaller logical chunks that are easier to reason about.
If the extra “noise” bothers you you can use —-first parent with git log.
- shruggedatlas 3y agoThis wouldn't affect what the reviewer sees because the squash commit only happens after the PR is complete and is being merged to master
- deleted 3y ago[deleted]
- bvrmn 3y agoFor more than 15 years of Git usage I've never seen a well crafted commit history for a single PR. It either a series of well crafted multiple PRs with separate reviews or a brain dumpster fire of multiple commits trying to make it work.
- loloquwowndueo 3y agoWell I have seen them. It’s your anecdata vs my anecdata :)
- bvrmn 3y agoIf you have public GH contributions you could show examples of PRs with stories told by commits and my anecdata would be invalid :)
- deleted 3y ago[deleted]