3 ms·
Code mods are fun. Were they gated by human PR reviews, perhaps in batches, or applied without review?
by banish-m4 2y ago
Code mods are fun. Were they gated by human PR reviews, perhaps in batches, or applied without review?
- zem 2y agoyes, gated by human reviews based on who owned the code, unless they were completely trivial and then were gated by a single global approver. there were always humans in the loop though.
- banish-m4 2y agoAh makes sense. At another MAANG, there was a code mod template job with a half dozen subvariants. I recall using a variant that supported ripgrep piping to sed -i for a simple replacement mod. There were jobs properties controlling how many mods per diff and whether it needed human approval or not. I think I did one batched by 1000 running once every 2 weeks to keep noise down.