2 ms·
How in the world is your rant in linked file supposed to work? * It seems you decide whether to execute a file by its extension, e.g. `.php` * You are complai
by Atomskun 2y ago
How in the world is your rant in linked file supposed to work?
* It seems you decide whether to execute a file by its extension, e.g. `.php`
* You are complaining that Windows is stripping away spaces, so `.php ` becomes `.php`
* And supposedly this could lead the file being served as static text if you didn't have a Windows workaround?
It rather seems to me that POSIX accepting `.php ` as a filename, and this not being picked up by a `.php` check is problematic here.
- mholt 2y agoNo, look at the associated unit test: https://github.com/caddyserver/caddy/blob/c6eb186064091c79f46d03fd0fc5c233c686566f/modules/caddyhttp/matchers_test.go#L432-L449 https://github.com/caddyserver/caddy/blob/c6eb186064091c79f4... If that test fails we could serve PHP source code instead of having it be evaluated, a potential security flaw.