3 ms·
Or just configure your code formatter to do this and forget about ever getting it wrong again.
by junon 3y ago
Or just configure your code formatter to do this and forget about ever getting it wrong again.
- brian-armstrong 3y agoThat doesn'f fix the ugly diff spam though
- junon 3y agoof course it does, why wouldn't it?
- brian-armstrong 3y agoWhat? How would it? Do you understand what is meant by that? The problem being referred to here is that a change on one line causes changes to unrelated lines. It makes it harder to pinpoint which line was changed intentionally in a diff and which ones were just caused by tab issues.
- junon 3y agoErr, yes, been coding for a while :D If you format before every commit, then the only changes you get are the changes you made.
- brian-armstrong 3y agoDoesn't help if you squash changes before merging, which is typical for large codebases
- junon 3y agoAgain, this makes absolutely no sense to me. I've never experienced any of the problems you're facing and I can't imagine how they'd even cause problems.
- brian-armstrong 3y agoIt's not clear why you're still defending this position. Feels like you made a not well considered, off the cuff remark about something. Rather than realize you were wrong and take the L, you're still doubling down? Is it that important to you?
- cqqxo4zV46cp 3y agoThat’s what ignored revisions are for.
- brian-armstrong 3y agoThat doesn't help the problem here. Part of the revision is still relevant (say, adding a new, longer field name to a struct) and the rest is just extra spam. But you wouldn't want to ignore the entire revision.
- junon 3y agoIt really sounds like you've not tried formatters before.