39 ms·

Do they even contribute back to llama.cpp in any meaningful way?

by ekianjo 3y ago

throwaway5959 3y ago
Are they under any obligation to?
- wokwokwok 3y ago
  There’s no legal obligation. …but I think it’s fair to say there’s a social obligation tip your hat to the shoulders you stand on. This has come up before, and they still do exactly the same thing, and there absolutely zero chance they haven’t heard the critique about it. So you must presume it’s a deliberate choice, rather than “oops we didn’t think of that”… /shrug If you don’t want to be called out for it, don’t do it. I’m not particularly sympathetic to them in this case.
  - deleted 3y ago
    [deleted]
- Zambyte 3y ago
  There is no license that obligates contributing upstream.
bertman 3y ago
They don't. I just checked: there's exactly one user that has contributed (only typo fixes) to both ollama and llama.cpp according to github's contributors graphs.
- anon373839 3y ago
  Isn’t llama.cpp low level and highly optimized? There may not be that much overlap in the required skill sets.
- JimDabell 3y ago
  This doesn’t seem correct to me. I saw in an Ollama issue mentioned in another comment, an Ollama contributor said: > As you pointed out, we carry patches, although in general we try to upstream those. — https://github.com/ollama/ollama/issues/2534#issuecomment-1955063232 https://github.com/ollama/ollama/issues/2534#issuecomment-19... So I followed the link to his profile and saw that he has opened some non-documentation pull requests for llama.cpp: https://github.com/ggerganov/llama.cpp/pull/5244 https://github.com/ggerganov/llama.cpp/pull/5244 https://github.com/ggerganov/llama.cpp/pull/5576 https://github.com/ggerganov/llama.cpp/pull/5576 I didn’t dig any deeper, but it took me less than thirty seconds to find those so I expect there are more.
  - bertman 3y ago
    Ah, thanks for this! I can't edit my parent comment that you replied to any longer unfortunately. As I said, I only compared the contributors graphs [0] and checked for overlaps. But those apparently only go back about year and only list at most 100 contributors ranked by number of commits. [0]: https://github.com/ollama/ollama/graphs/contributors https://github.com/ollama/ollama/graphs/contributors and https://github.com/ggerganov/llama.cpp/graphs/contributors https://github.com/ggerganov/llama.cpp/graphs/contributors

Do they even contribute back to llama.cpp in any meaningful way?

throwaway5959 3y ago

Are they under any obligation to?

wokwokwok 3y ago
There’s no legal obligation. …but I think it’s fair to say there’s a social obligation tip your hat to the shoulders you stand on. This has come up before, and they still do exactly the same thing, and there absolutely zero chance they haven’t heard the critique about it. So you must presume it’s a deliberate choice, rather than “oops we didn’t think of that”… /shrug If you don’t want to be called out for it, don’t do it. I’m not particularly sympathetic to them in this case.
- deleted 3y ago
  [deleted]
Zambyte 3y ago
There is no license that obligates contributing upstream.

bertman 3y ago

They don't. I just checked: there's exactly one user that has contributed (only typo fixes) to both ollama and llama.cpp according to github's contributors graphs.

anon373839 3y ago
Isn’t llama.cpp low level and highly optimized? There may not be that much overlap in the required skill sets.
JimDabell 3y ago
This doesn’t seem correct to me. I saw in an Ollama issue mentioned in another comment, an Ollama contributor said: > As you pointed out, we carry patches, although in general we try to upstream those. — https://github.com/ollama/ollama/issues/2534#issuecomment-1955063232 https://github.com/ollama/ollama/issues/2534#issuecomment-19... So I followed the link to his profile and saw that he has opened some non-documentation pull requests for llama.cpp: https://github.com/ggerganov/llama.cpp/pull/5244 https://github.com/ggerganov/llama.cpp/pull/5244 https://github.com/ggerganov/llama.cpp/pull/5576 https://github.com/ggerganov/llama.cpp/pull/5576 I didn’t dig any deeper, but it took me less than thirty seconds to find those so I expect there are more.
- bertman 3y ago
  Ah, thanks for this! I can't edit my parent comment that you replied to any longer unfortunately. As I said, I only compared the contributors graphs [0] and checked for overlaps. But those apparently only go back about year and only list at most 100 contributors ranked by number of commits. [0]: https://github.com/ollama/ollama/graphs/contributors https://github.com/ollama/ollama/graphs/contributors and https://github.com/ggerganov/llama.cpp/graphs/contributors https://github.com/ggerganov/llama.cpp/graphs/contributors