4 ms·
> then contributing a clean PR with bundled documentation and tests. I've never seen this. No tests, un-clean PR. Describing them how to fix it would take more
by nox101 3y ago
> then contributing a clean PR with bundled documentation and tests.
I've never seen this. No tests, un-clean PR. Describing them how to fix it would take more time than re-doing the PR myself. Of course maybe if I thought they were going to contribute a bunch more PRs it would be worth spending time training them but I've never had that kind of contributor.
- simonw 3y agoI had one of these recently! https://github.com/simonw/shot-scraper/pull/133/files https://github.com/simonw/shot-scraper/pull/133/files They're /incredibly/ rare though.