2 ms·
To be super clear, I'm not a fan of this specific thing. The rest of csvbase may be the best thing ever! This kind of configuration feels very magical in that
by kstrauser 3y ago
To be super clear, I'm not a fan of this specific thing. The rest of csvbase may be the best thing ever!
This kind of configuration feels very magical in that it's completely behind the scenes. There's nothing in code I can look at that says "this URL should be handed to this adapter". There's no env var that gets slurped in. No .env file that's parsed. There's nothing checked into git that tells me how that URL scheme could possibly work, except the existence of a package in pyproject.toml -- one that's not even imported, just present.
That makes it stateful in a bad way. If `poetry install` (or `pip install -r requirements.txt` or whatever) didn't complete, the module using it will still load and run up until the point that it crashes because that URL doesn't load. If I ran an automated process to prune unused modules from poetry/pip, suddenly behavior changes. I don't like that idea one bit.