3 ms·
According to `git blame`, this was introduced June 2023, i.e. after your audit in 2019. But maybe it was moved from an older piece of the codebase, I didn't dig
by woodruffw 3y ago
According to `git blame`, this was introduced June 2023, i.e. after your audit in 2019. But maybe it was moved from an older piece of the codebase, I didn't dig too deep.
(Looks like the IncludeSec folks did a decent job in 2019. Hi Eric!)
- dignifiedquire 3y agoThis was allowed in the rust-rsa crate directly before, which is why it was introduced in that commit.
- woodruffw 3y agoYep, I saw the upstream[1]. However, I misread this: I thought the padding was being done on the cleartext signing side, but this is padding of the signature itself. So there's some malleability here, but it isn't susceptible to DO'1985. I'll update my top-level comment. [1]: https://github.com/RustCrypto/RSA/issues/272 https://github.com/RustCrypto/RSA/issues/272
- dignifiedquire 3y agoThanks, appreciate the careful check!
- junon 3y agoGlad people care to look, that's what matters.