4 ms·

no diff referenced, incompetency or pr campaing from hc

• dartos 3y ago
  There are links to 3 files in both opentofu and hashicorp. You could get the diff yourself from that. The point about the header comments is pretty damming. It’s probably just laziness / not knowing how to make diffs from 2 different repos.
  • linuxftw 3y ago
    The bit about the header comments is misleading, as OpenTofu attributes themselves and hashicorp, at least on the first file. If they used any snippets of code from another file in the open source codebase (eg, moved probably has very similar functionality under the hood), then it would be appropriate to attribute that code the the original author.
  • tsimionescu 3y ago
    I looked at the pull request that added this new feature and it didn't seem to touch the headers at all. My guess is that the headers are left over from before the fork, and anyway they are true, HashiCorp still holds the copyright to the majority of that code. Later edit: for new files, it seems that the old copyright notice was kept until a new copyright notice was settled on [0], and anyway even the new copyright notice references HashiCorp as well [1] (I don't know the history, but possibly because they could be considered derived works?). [0] https://github.com/opentofu/opentofu/pull/1158/commits/35d1ae31b46a63f14ab0b967c14d236f690185d9#r1465188714 https://github.com/opentofu/opentofu/pull/1158/commits/35d1a... [1] https://github.com/opentofu/opentofu/issues/454#issuecomment-1904213569 https://github.com/opentofu/opentofu/issues/454#issuecomment...
  • mirekrusin 3y ago
    He's got a point because if you look at first example (didn't bother to look at others) the diff is substantial and invalidates argument made in the article. Embedding diff in website is super easy novadays and whole article talks about just that.